Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix local --global install #844

Merged
merged 1 commit into from
Dec 14, 2021
Merged

fix local --global install #844

merged 1 commit into from
Dec 14, 2021

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl self-assigned this Dec 14, 2021
@casperdcl casperdcl temporarily deployed to internal December 14, 2021 19:20 Inactive
0x2b3bfa0
0x2b3bfa0 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw this in StackOverflow half an hour ago, but couldn't believe it was “the” solution. If this is the only way, it works for me.

@casperdcl
Copy link
Contributor Author

Won't be able to tell if fixed until after it's merged :/

@casperdcl casperdcl added bug Something isn't working flaky Heisenbugs testing Unit tests & debugging labels Dec 14, 2021
@0x2b3bfa0
Copy link
Member

🔮 It works 🐡

@0x2b3bfa0
Copy link
Member

Merging red because it's going to fail until merged. We use pull_request_target everywhere.

@0x2b3bfa0 0x2b3bfa0 merged commit 957eeba into master Dec 14, 2021
@0x2b3bfa0 0x2b3bfa0 deleted the npm-i-g-local branch December 14, 2021 19:29
@casperdcl casperdcl mentioned this pull request Dec 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

@DavidGOrtega DavidGOrtega Awaiting requested review from DavidGOrtega

Assignees

@casperdcl casperdcl

Labels
bug Something isn't working flaky Heisenbugs testing Unit tests & debugging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find module 'pseudoexec'
2 participants
@casperdcl @0x2b3bfa0